| From: | Simon Riggs <simon(at)2ndQuadrant(dot)com> |
|---|---|
| To: | Stephen Frost <sfrost(at)snowman(dot)net> |
| Cc: | Jim Nasby <jim(at)nasby(dot)net>, Kevin Grittner <Kevin(dot)Grittner(at)wicourts(dot)gov>, Andres Freund <andres(at)anarazel(dot)de>, aidan(at)highrise(dot)ca, stark(at)mit(dot)edu, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: 16-bit page checksums for 9.2 |
| Date: | 2012-01-06 10:30:53 |
| Message-ID: | CA+U5nMK9xVMb69UPnseQ5pjnUuh85NW+daREFayjgZ8FXj1WUg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Jan 6, 2012 at 1:10 AM, Stephen Frost <sfrost(at)snowman(dot)net> wrote:
> * Simon Riggs (simon(at)2ndQuadrant(dot)com) wrote:
>> I discover that non-all-zeroes holes are fairly common, just not very frequent.
>
> Curious, might be interesting to find out why.
>
>> That may or may not be a problem, but not something to be dealt with
>> here and now.
>
> But I agree that it's not the job of this patch/effort. It sounds like
> we have clear indication, however, that those areas, as they are not
> necessairly all zeros, should be included in the checksum.
Disagree. Full page writes ignore the hole, so its appropriate to do
so here also.
--
Simon Riggs http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2012-01-06 10:36:08 | Re: 16-bit page checksums for 9.2 |
| Previous Message | Simon Riggs | 2012-01-06 09:08:15 | Re: CLOG contention |