Re: pgsql: Resolve timing issue with logging locks for Hot Standby.

From: Simon Riggs <simon(at)2ndQuadrant(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Resolve timing issue with logging locks for Hot Standby.
Date: 2012-01-30 09:13:04
Message-ID: CA+U5nMJZOYLq00gbn2TV7iN_P70HqSZjym15_N4wTt6T+zOztg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Mon, Jan 30, 2012 at 12:30 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Simon Riggs <simon(at)2ndQuadrant(dot)com> writes:
>> Resolve timing issue with logging locks for Hot Standby.
>> We log AccessExclusiveLocks for replay onto standby nodes,
>> but because of timing issues on ProcArray it is possible to
>> log a lock that is still held by a just committed transaction
>> that is very soon to be removed. To avoid any timing issue we
>> avoid applying locks made by transactions with InvalidXid.
>
>> Simon Riggs, bug report Tom Lane, diagnosis Pavan Deolasee
>
> I see this was only applied to HEAD.  Wouldn't back-patching be in
> order?  The problem is in 9.1 as well, no?

Yes, it is. I prefer to give a little time before backpatching to
avoid mistakes (of my own making), especially since we're busy enough
not to want to divert energy to other releases right now. The patch
will make it in before next minor release.

--
 Simon Riggs                   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Heikki Linnakangas 2012-01-30 09:54:35 pgsql: Accept a non-existent value in "ALTER USER/DATABASE SET ..." com
Previous Message User Marian 2012-01-30 08:22:32 jsonpath - postgresql-json: Fix bug: json_check not crash if json is