| From: | Simon Riggs <simon(at)2ndQuadrant(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)2ndquadrant(dot)com> |
| Cc: | Magnus Hagander <magnus(at)hagander(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Petr Jelinek <petr(at)2ndquadrant(dot)com> |
| Subject: | Re: recovery_target_action = pause & hot_standby = off |
| Date: | 2015-03-15 20:10:49 |
| Message-ID: | CA+U5nMJQ-ox02GBtY1s-8LVT=a76aMahqxKWHGxSUQR23MgCpw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 15 March 2015 at 14:16, Andres Freund <andres(at)2ndquadrant(dot)com> wrote:
> Personally I think we just should change the default to 'shutdown' for
> all cases. That makes documentation and behaviour less surprising. And
> makes experimenting less dangerous, since you can just start again.
We need to look at the specific situation, not make a generic decision.
If hot_standby = off, we are unable to unpause, once paused.
Changing the default doesn't alter that problem.
We have two choices: 1) override to a sensible setting, 2) throw an error.
(2) sounds clean at first but we must look deeper. We know that the
*only* possible other setting is 'shutdown', so it seems more user
friendly to do the thing we *know* they want (1), rather than pretend
that we don't.
(1) is completely predictable and not at all surprising. Add a LOG
message if you wish, but don't throw an error.
--
Simon Riggs http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, RemoteDBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Petr Jelinek | 2015-03-15 20:47:40 | Re: Using 128-bit integers for sum, avg and statistics aggregates |
| Previous Message | Fabien COELHO | 2015-03-15 19:35:08 | Re: PATCH: pgbench - merging transaction logs |