Re: Poorly thought out code in vacuum

From: Simon Riggs <simon(at)2ndQuadrant(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Poorly thought out code in vacuum
Date: 2012-01-06 14:53:33
Message-ID: CA+U5nM+DZ9jraZ_wCUBqq4+5jpEhrEW13ySpYn40GZmAntM6-Q@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Jan 6, 2012 at 2:29 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Thu, Jan 5, 2012 at 7:37 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> I suppose Robert had something more intelligent in mind than a tight
>> loop when the buffer can't be exclusively locked, so maybe there is
>> some other change that should be made here instead.
>
> My intention was to skip the tuple, but I failed to notice the unusual
> way in which this loop iterates.  How about something like the
> attached?

It solves the waiting issue, but leaves unused tuples in the heap that
previously would have been removed.

I don't think that is a solution.

--
 Simon Riggs                   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2012-01-06 15:28:40 Re: Poorly thought out code in vacuum
Previous Message Robert Haas 2012-01-06 14:29:39 Re: Poorly thought out code in vacuum