Re: Binary upgrade from <12 to 12 creates toast table for partitioned tables

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
Subject: Re: Binary upgrade from <12 to 12 creates toast table for partitioned tables
Date: 2019-03-07 18:36:06
Message-ID: CA+Tgmobzuh9px4huEe7cS1OKGQLMv=nXWkkYTY3H1UOaK0GHSw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Mar 7, 2019 at 1:17 PM Andres Freund <andres(at)anarazel(dot)de> wrote:
> > > While I'm not hugely bothered by binary upgrade mode creating
> > > inconsistent states - there's plenty of ways to crash the server that
> > > way - it probably also would be a good idea to have heap_create()
> > > elog(ERROR) when accessmtd is invalid.
> >
> > Not sure about this part.
>
> As in, we shouldn't elog out? Or we should have an ereport with a proper
> error, or ...?

As in, I don't understand the problem well enough to have an informed opinion.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Arthur Zakirov 2019-03-07 18:49:33 Re: [PROPOSAL] Drop orphan temp tables in single-mode
Previous Message Alvaro Herrera 2019-03-07 18:34:22 Re: Binary upgrade from <12 to 12 creates toast table for partitioned tables