Re: refactoring basebackup.c

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Jeevan Ladhe <jeevan(dot)ladhe(at)enterprisedb(dot)com>
Cc: Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, tushar <tushar(dot)ahuja(at)enterprisedb(dot)com>
Subject: Re: refactoring basebackup.c
Date: 2021-09-09 23:55:31
Message-ID: CA+TgmobvHoqeMc2+h8GRnvf2oLxpZkq1F8rS6fa47uk92QAxhw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Sep 8, 2021 at 3:39 PM Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> The way the gzip APIs I used work, you tell it how big the output
> buffer is and it writes until it fills that buffer, or until the input
> buffer is empty, whichever happens first. But this seems to be the
> other way around: you tell it how much input you have, and it tells
> you how big a buffer it needs. To handle that elegantly, I think I
> need to make some changes to the design of the bbsink stuff. What I'm
> thinking is that each bbsink somehow tells the next bbsink how big to
> make the buffer.

Here's a new patch set with that design change (and a bug fix for 0001).

--
Robert Haas
EDB: http://www.enterprisedb.com

Attachment Content-Type Size
v4-0007-WIP-Server-side-gzip-compression.patch application/octet-stream 17.6 KB
v4-0004-Introduce-bbstreamer-abstraction-to-modularize-pg.patch application/octet-stream 80.3 KB
v4-0006-Support-base-backup-targets.patch application/octet-stream 32.0 KB
v4-0005-Modify-pg_basebackup-to-use-a-new-COPY-subprotoco.patch application/octet-stream 33.8 KB
v4-0001-Flexible-options-for-BASE_BACKUP-and-CREATE_REPLI.patch application/octet-stream 24.6 KB
v4-0002-Refactor-basebackup.c-s-_tarWriteDir-function.patch application/octet-stream 4.0 KB
v4-0003-Introduce-bbsink-abstraction-to-modularize-base-b.patch application/octet-stream 76.7 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Fujii Masao 2021-09-10 00:23:45 Re: Allow escape in application_name
Previous Message Jacob Champion 2021-09-09 23:44:09 Re: PROXY protocol support