Re: pgsql: Rewrite the code that applies scan/join targets to paths.

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pgsql: Rewrite the code that applies scan/join targets to paths.
Date: 2018-03-30 15:45:43
Message-ID: CA+Tgmobuhy_LR+f8=mw5BDBUsNpwLNYi+fcrkuRjD+S24E_CHw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Fri, Mar 30, 2018 at 1:03 AM, Andres Freund <andres(at)anarazel(dot)de> wrote:
> Not 100% sure it's this patch, but if not, it's also one of the ones you
> committed ;)

Looks like it.

> There's a valgrind complaint:
> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=lousyjack&dt=2018-03-30%2002%3A03%3A01
>
> Last file mtime in snapshot: Fri Mar 30 01:25:39 2018 GMT
> ===================================================
> ==6442== Invalid read of size 4
> ==6442== at 0x78D725: apply_scanjoin_target_to_paths (planner.c:6843)

I've committed an attempt at a fix.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2018-03-30 15:48:33 pgsql: Do index FSM vacuuming sooner.
Previous Message Robert Haas 2018-03-30 15:45:33 pgsql: Don't call IS_DUMMY_REL() when cheapest_total_path might be junk

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2018-03-30 15:54:45 Re: JIT compiling with LLVM v12.2
Previous Message Dagfinn Ilmari =?utf-8?Q?Manns=C3=A5ker?= 2018-03-30 15:21:26 Re: Cast jsonb to numeric, int, float, bool