| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
| Cc: | David Fetter <david(at)fetter(dot)org>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: CREATE FOREGIN TABLE LACUNA |
| Date: | 2012-03-15 15:58:57 |
| Message-ID: | CA+TgmobscZC=z4Qb8YeT=UdF_+_9ZPwGJGeXnaFpdLw7h14=RQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Mar 15, 2012 at 10:23 AM, Alvaro Herrera
<alvherre(at)commandprompt(dot)com> wrote:
> Looks much better to me, but the use of strcmp() doesn't look good.
> ISTM that stmtType is mostly used for error messages. I think you
> should add some kind of identifier (such as the original parser Node)
> into the CreateStmtContext so that you can do a IsA() test instead -- a
> bit more invasive as a patch, but much cleaner.
+1. Or maybe add a relkind to CreateStmt, if it isn't there already,
and test that.
> Also the error messages need more work.
+1. I suggest something like "ERROR: foreign tables do not support
LIKE INCLUDING INDEXES".
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Greg Stark | 2012-03-15 17:45:16 | Re: pg_upgrade and statistics |
| Previous Message | David Fetter | 2012-03-15 15:53:42 | Re: CREATE FOREGIN TABLE LACUNA |