| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Atsushi Torikoshi <atorik(at)gmail(dot)com> |
| Cc: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Julien Rouhaud <rjuju123(at)gmail(dot)com>, Arthur Zakirov <zaartur(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Add pg_file_sync() to adminpack |
| Date: | 2020-01-16 14:51:24 |
| Message-ID: | CA+TgmobsFt0pfNCihaFJK9EE-hA+CHPiwmv9t9P_JbPAGhZnUA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Jan 14, 2020 at 10:08 AM Atsushi Torikoshi <atorik(at)gmail(dot)com> wrote:
> fails we can get error messages. So it seems straightforward for me to
> 'return true on success and emit an ERROR otherwise'.
I agree with reporting errors using ERROR, but it seems to me that we
ought to then make the function return 'void' rather than 'bool'.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Li Japin | 2020-01-16 15:18:43 | Code cleanup for build_regexp_split_result |
| Previous Message | Justin Pryzby | 2020-01-16 14:38:46 | Re: [PATCH v1] pg_ls_tmpdir to show directories |