| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | "Bossart, Nathan" <bossartn(at)amazon(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Andres Freund <andres(at)anarazel(dot)de>, amul sul <sulamul(at)gmail(dot)com> |
| Subject: | Re: RecoveryInProgress() has critical side effects |
| Date: | 2021-12-07 22:55:02 |
| Message-ID: | CA+Tgmobrw_+7F5JmYQP4u4sZRqE1MExPFGMAOuA-TfW1=NghJA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, Dec 4, 2021 at 7:44 PM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> My main worry here is that this changes slightly the definition of
> doPageWrites across stable branches at the end of recovery as there
> could be records generated there. Note that GetFullPageWriteInfo()
> gets called in XLogInsert(), while Insert->fullPageWrites gets updated
> before CleanupAfterArchiveRecovery(). And it may influence
> the value of doPageWrites in the startup process.
But ... so what? All the code that uses it retries if the value that
was tentatively used turns out to be wrong.
--
Robert Haas
EDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Geoghegan | 2021-12-07 23:20:16 | Re: Why doesn't pgstat_report_analyze() focus on not-all-visible-page dead tuple counts, specifically? |
| Previous Message | Bossart, Nathan | 2021-12-07 22:47:18 | Re: Should we improve "PID XXXX is not a PostgreSQL server process" warning for pg_terminate_backend(<<postmaster_pid>>)? |