Re: incremental backup mishandles XLOG_DBASE_CREATE_FILE_COPY

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Noah Misch <noah(at)leadboat(dot)com>
Cc: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: incremental backup mishandles XLOG_DBASE_CREATE_FILE_COPY
Date: 2024-03-04 18:37:39
Message-ID: CA+TgmobrrggaHhz=+9U3ebDHUPkv7KUzQPr_fre1rOC=MBFfvQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Feb 24, 2024 at 12:10 PM Noah Misch <noah(at)leadboat(dot)com> wrote:
> Agreed, those don't touch relation data files. I think you've got all
> relation data file mutations. XLOG_DBASE_CREATE_FILE_COPY and XLOG_DBASE_DROP
> are the only record types that touch a relation data file without mentioning
> it in XLogRecordBlockHeader, XACT_XINFO_HAS_RELFILELOCATORS, or an RM_SMGR_ID
> rlocator field.

Thanks for the review. I have committed this.

--
Robert Haas
EDB: http://www.enterprisedb.com

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Banck 2024-03-04 19:42:55 Re: [PATCH] Exponential backoff for auth_delay
Previous Message Andres Freund 2024-03-04 18:33:55 Re: Tidy fill hstv array (src/backend/access/heap/pruneheap.c)