Re: pgsql: tableam: New callback relation_fetch_toast_slice.

On Tue, Jan 7, 2020 at 10:27 PM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> anole does not compile after this commit:
> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=anole&dt=2020-01-08%2001%3A54%3A11
>
> From the logs:
> make[4]: Entering directory
> `/home/pgbfarm/buildroot/HEAD/pgsql.build/src/backend/access/brin'
> cc +Olibmerrno -g +DD64 -I../../../../src/include
> -D_XOPEN_SOURCE_EXTENDED
> -I/opt/packages/libxml2-2.7.8/inst/include/libxml2
> -I/opt/packages/zlib-1.2.5/inst/include
> -I/opt/packages/libxslt-1.1.26/inst/include
> -I/opt/packages/libxml2-2.7.8/inst/include -c -o brin.o brin.c
> "../../../../src/include/access/tableam.h", line 1662: error #2118: a
> void function may not return a value
> return
> toastrel->rd_tableam->relation_fetch_toast_slice(toastrel,
> valueid,
> ^

Huh, I'm surprised that didn't break everywhere. Pushed a fix.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company