| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | horiguchi(dot)kyotaro(at)oss(dot)ntt(dot)co(dot)jp, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: [v9.2] make_greater_string() does not return a string in some cases |
| Date: | 2011-10-30 18:49:40 |
| Message-ID: | CA+TgmobobRMe6gC9S2ijS7=9HtptP1fX41AMV5y4L+b1PG6ApQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs pgsql-hackers |
On Sun, Oct 30, 2011 at 10:58 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> You are misreading the old code. The inner loop increments the last
> byte, checks for success, and if it hasn't produced a greater string
> then it loops around to increment again.
Ugh. You're right.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2011-10-30 19:09:34 | Re: BUG #6277: Money datatype conversion wrong with Russian locale |
| Previous Message | Tom Lane | 2011-10-30 14:58:53 | Re: [v9.2] make_greater_string() does not return a string in some cases |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2011-10-30 18:54:35 | Re: Thoughts on "SELECT * EXCLUDING (...) FROM ..."? |
| Previous Message | Jim Nasby | 2011-10-30 18:15:01 | Re: Thoughts on "SELECT * EXCLUDING (...) FROM ..."? |