| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Dilip Kumar <dilipbalaut(at)gmail(dot)com> |
| Cc: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: XLogBeginRead's header comment lies |
| Date: | 2022-08-17 14:57:27 |
| Message-ID: | CA+Tgmobo3_10=NTmP+=9KjaUP2OcnSWKgF-7gvts22Y3X9_KGQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Aug 17, 2022 at 6:53 AM Dilip Kumar <dilipbalaut(at)gmail(dot)com> wrote:
> Thinking again, there is already a code in XLogDecodeNextRecord() to
> error out if XLP_FIRST_IS_CONTRECORD is set so probably we don't need
> to do anything else and the previous patch with modified assert should
> just work fine?
Yeah, that looks right to me. I'm inclined to commit your patch with
some changes to wording of the comments. I'm also inclined not to
back-patch, since we don't know that this breaks anything for existing
users of the xlogreader facility.
If anyone doesn't want this committed or does want it back-patched,
please speak up.
Thanks,
--
Robert Haas
EDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Vivian Kong | 2022-08-17 15:07:16 | RE: s390x builds on buildfarm |
| Previous Message | Justin Pryzby | 2022-08-17 14:54:35 | shadow variables - pg15 edition |