Re: Patch for ginCombineData

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Robert Abraham <robert(dot)abraham86(at)googlemail(dot)com>
Cc: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Patch for ginCombineData
Date: 2015-08-08 14:04:04
Message-ID: CA+TgmobnaSXd1wtcrpWomnLqh8p8bC5E+jsTZGsBQYCj25x5qw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Aug 5, 2015 at 6:17 AM, Robert Abraham
<robert(dot)abraham86(at)googlemail(dot)com> wrote:
> we are using gin indexes on big tables. these tables happen to have several
> billion rows.
> the index creation fails in ginCombineData in src/backend/access/ginbulk.c
> because repalloc is limited to 1 gb.
> this limitation makes no sense in this context (compare comments in
> src/include/utils/memutils.h).
> To overcome this limitation on tables with lots of rows repalloc_huge is
> used.
> The test suite still succeeds on my machine.
> Find the patch attached,

Since nobody seems ready to act on this patch immediately, I suggest
adding it here so it doesn't get forgotten:

https://commitfest.postgresql.org/action/commitfest_view/open

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2015-08-08 14:08:35 Re: Add column-name hint to log messages generated by inserts when varchars don't fit
Previous Message Robert Haas 2015-08-08 14:02:38 Re: max_worker_processes on the standby