| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Amit Khandekar <amitdkhan(dot)pg(at)gmail(dot)com> |
| Cc: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> |
| Subject: | Re: [HACKERS] UPDATE of partition key |
| Date: | 2018-01-04 21:34:18 |
| Message-ID: | CA+TgmobmRV+vvYEHAiTV_6=RyWXx+hSVX_+vEkmQ6uvmPrM7qA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Jan 3, 2018 at 6:29 AM, Amit Khandekar <amitdkhan(dot)pg(at)gmail(dot)com> wrote:
> ExecSetupPartitionTupleRouting() now returns PartitionTupleRouting *.
>
> Did this change in v3 version of
> 0001-Encapsulate-partition-related-info-in-a-structure.patch
I'll have to come back to some of the other open issues, but 0001 and
0005 look good to me now, so I pushed those as a single commit after
fixing a few things that pgindent didn't like. I also think 0002 and
0003 look basically good, so I pushed those two as a single commit
also. But the comment changes in 0003 didn't seem extensive enough to
me so I made a few more changes there along the way.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alexander Korotkov | 2018-01-04 21:36:57 | Re: [HACKERS] [PATCH] Incremental sort |
| Previous Message | Alvaro Herrera | 2018-01-04 21:26:58 | Re: Finalizing logical replication limitations as well as potential features |