Re: PATCH: Avoid use of __attribute__ when building with old Sun compiler versions

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Andy Grundman <andyg(at)activestate(dot)com>
Cc: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: PATCH: Avoid use of __attribute__ when building with old Sun compiler versions
Date: 2016-09-14 22:34:58
Message-ID: CA+Tgmobk=BYNsPd0k9OZpzAgmheJ0n=3ZfaMiQSkYSAgonr_TQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Sep 2, 2016 at 11:55 AM, Andy Grundman <andyg(at)activestate(dot)com> wrote:
> The use of __attribute__ is currently enabled by checking for
> __SUNPRO_C. However, this compiler only added support for
> __attribute__ keywords in version 5.10 [1]. This patch adds a version
> check to only enable this for supported versions [2].
>
> I have tested this with Sun C 5.8 on a Solaris 9 SPARC system,
> building 9.5.4 (+OpenSSL 1.1.0 patches).

Wow, so we'd need this if building on a compiler released before June
2007. Is this the only change that's needed to build with the older
compiler? Can you set up a buildfarm member for this platform?

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Keith Fiske 2016-09-14 22:48:59 Re: kqueue
Previous Message Jeff Janes 2016-09-14 22:34:44 Re: Hash Indexes