| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [COMMITTERS] pgsql: pageinspect: Try to fix some bugs in previous commit. |
| Date: | 2017-02-03 16:18:07 |
| Message-ID: | CA+Tgmobhj6JgsQFNeQUKY9OktC2FL1VWv6XatNabKGPEujpC2Q@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Fri, Feb 3, 2017 at 7:41 AM, Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com> wrote:
>> I think for now selecting named fields is sufficient.
>
> +1. Attached is the patch that has this changes.
Thanks for the patch, but you only handled one of the two cases Tom
reported upthread. Added a fix for the other one and committed the
result as 29e312bc1301061ae9f897ff39f3b230c421a5fb.
Hopefully that will turn the buildfarm green again, but we'll see.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2017-02-03 16:35:03 | pgsql: In pageinspect/hashfuncs.c, avoid crashes on alignment-picky mac |
| Previous Message | Robert Haas | 2017-02-03 16:12:02 | pgsql: pageinspect: Remove platform-dependent values from hash tests. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2017-02-03 16:35:14 | Re: [COMMITTERS] pgsql: pageinspect: Try to fix some bugs in previous commit. |
| Previous Message | Corey Huinker | 2017-02-03 16:08:07 | Re: \if, \elseif, \else, \endif (was Re: PSQL commands: \quit_if, \quit_unless) |