| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
| Cc: | Kuntal Ghosh <kuntalghosh(dot)2007(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Peter Geoghegan <pg(at)heroku(dot)com>, Simon Riggs <simon(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Amit Kapila <amit(dot)kapila(at)enterprisedb(dot)com> |
| Subject: | Re: WAL consistency check facility |
| Date: | 2016-11-01 13:31:17 |
| Message-ID: | CA+TgmobhfC2zeECBdXhgj4+PysTyhBVvUM4WyDRXSPFNpsyrgg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Oct 31, 2016 at 5:51 PM, Michael Paquier
<michael(dot)paquier(at)gmail(dot)com> wrote:
> Hehe, I was expecting you to jump on those lines. While looking at the
> patch I have simplified it first to focus on the core engine of the
> thing. Adding back this code sounds fine to me as there is a wall of
> contestation. I offer to do it myself if the effort is the problem.
IMHO, your rewrite of this patch was a bit heavy-handed. I haven't
scrutinized the code here so maybe it was a big improvement, and if so
fine, but if not it's better to collaborate with the author than to
take over. In any case, yeah, I think you should put that back.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Merlin Moncure | 2016-11-01 13:35:15 | Re: emergency outage requiring database restart |
| Previous Message | Michael Paquier | 2016-11-01 13:29:59 | Re: Fix bug in handling of dropped columns in pltcl triggers |