Re: new heapcheck contrib module

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Peter Geoghegan <pg(at)bowt(dot)ie>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: new heapcheck contrib module
Date: 2020-07-31 19:16:39
Message-ID: CA+Tgmobg_M3zcL=PepSubVtgG6m4Cw_zR48eqDavySwKHeE83Q@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Jul 31, 2020 at 3:05 PM Andres Freund <andres(at)anarazel(dot)de> wrote:
> The page could have been wrongly marked all-frozen. There could be
> interactions between heap and toast table that are checked. Other bugs
> could apply, like a broken hot chain or such.

OK, at least the first two of these do sound like problems. Not sure
about the third one.

> > If we do need to do something special in terms of advertising xmin,
> > how would you do it? Normally it happens by registering a snapshot,
> > but here all we would have is an XID; specifically, the value of
> > relfrozenxid that we observed.
>
> An appropriate procarray or snapmgr function would probably suffice?

Not sure; I guess that'll need some investigation.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2020-07-31 19:17:55 Re: [Patch] Optimize dropping of relation buffers using dlist
Previous Message Daniel Gustafsson 2020-07-31 19:10:23 Re: [PATCH] Support built control file in PGXS VPATH builds