From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
---|---|
To: | Heikki Linnakangas <hlinnakangas(at)vmware(dot)com> |
Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Moving src/backend/utils/misc/rbtree.c to src/backend/lib |
Date: | 2014-12-22 15:44:50 |
Message-ID: | CA+TgmobgF-D7BHBF0G-yn5w+Ug+50EwC1goYMmwhb4ZqwKTJCQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Mon, Dec 22, 2014 at 5:16 AM, Heikki Linnakangas
<hlinnakangas(at)vmware(dot)com> wrote:
> Peter Geoghegan suggested [1] moving rbtree.c to src/backend/lib, which I
> think makes a lot of sense. Now that we have several other general purpose
> data structures in src/backend/lib (linked lists, a binary heap, and a
> pairing heap), rbtree.c would definitely be better placed in
> src/backend/lib, too.
>
> The usual objection to moving things is that it makes back-patching harder.
> It also might break third-party code that use it (since presumably we would
> also move the .h file). Nevertheless, I feel the advantages outweigh the
> disadvantages in this case.
I agree.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2014-12-22 15:46:16 | Re: Final Patch for GROUPING SETS |
Previous Message | Tom Lane | 2014-12-22 15:36:17 | Re: inherit support for foreign tables |