| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: allow_in_place_tablespaces vs. pg_basebackup |
| Date: | 2023-03-22 17:14:09 |
| Message-ID: | CA+Tgmobf-Ra_vAqX8LywPxQ5UL-qHsU3tA45Ay9JwGkCcmROnA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Mar 21, 2023 at 7:59 PM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> On Mon, Mar 20, 2023 at 07:56:42AM -0400, Robert Haas wrote:
> > Anyone want to comment on this?
>
> I have not checked the patch in details, but perhaps this needs at
> least one test?
Sure. I was sort of hoping to get feedback on the overall plan first,
but it's easy enough to add a test so I've done that in the attached
version. I've put it in a separate file because 010_pg_basebackup.pl
is pushing a thousand lines and it's got a ton of unrelated tests in
there already. The test included here fails on master, but passes with
the patch.
--
Robert Haas
EDB: http://www.enterprisedb.com
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Fix-pg_basebackup-with-in-place-tablespaces-some-.patch | application/octet-stream | 11.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Melanie Plageman | 2023-03-22 17:20:51 | Re: Add pg_walinspect function with block info columns |
| Previous Message | Tom Lane | 2023-03-22 17:04:35 | Re: Set arbitrary GUC options during initdb |