Re: parallel.c is not marked as test covered

On Sun, Jun 19, 2016 at 5:22 PM, Peter Eisentraut
<peter(dot)eisentraut(at)2ndquadrant(dot)com> wrote:
> Well, the purpose of the test is to check the error passing between worker
> and leader. If we just silently revert to not doing that, then we can't
> really be sure that we're testing the right thing. We've already seen some
> instances in this thread where we figured out after some debugging that some
> construct is not actually going through the parallel infrastructure, so I'm
> afraid if we leave it like this it might silently change behavior at some
> point in the future.

I've been thinking about renaming the "single_copy" flag for Gather
nodes to something like "pipeline" or some other term that might hope
to convey that the leader won't participate unless no workers can be
launched at all, and then adding an option to force that to be used
always. That would allow better testing here, although I fear we
might be getting to a level of tinkering with parallel query that
starts to look more like feature development.

> Independent of that, it would help testing things like this if we allowed
> setting max_worker_processes to 0, instead of the current minimum 1. If
> there a reason for the minimum of 1?

I believe that's pure brain fade on my part. I think the minimum should be 0.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company