| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi> |
| Cc: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [COMMITTERS] pgsql: In checkpoint, move the check for in-progress xacts out of criti |
| Date: | 2014-04-04 15:06:16 |
| Message-ID: | CA+Tgmobcm+ZAMD7Evpi+MJJ8bMQQy=UYU0E-f4nrdzr1PC_XEA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Fri, Apr 4, 2014 at 10:32 AM, Heikki Linnakangas
<heikki(dot)linnakangas(at)iki(dot)fi> wrote:
> In checkpoint, move the check for in-progress xacts out of critical section.
>
> GetVirtualXIDsDelayingChkpt calls palloc, which isn't safe in a critical
> section. I thought I covered this case with the exemption for the
> checkpointer, but CreateCheckPoint is also called from the startup process.
This commit un-broke "make check", which you might have wanted to run
before committing, but "make -C src/test/isolation check" is still
broken.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Heikki Linnakangas | 2014-04-04 15:26:04 | pgsql: Move multixid allocation out of critical section. |
| Previous Message | Heikki Linnakangas | 2014-04-04 14:32:08 | pgsql: In checkpoint, move the check for in-progress xacts out of criti |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2014-04-04 15:07:26 | Re: GiST support for inet datatypes |
| Previous Message | Andres Freund | 2014-04-04 15:01:34 | Re: integrate pg_upgrade analyze_new_cluster.sh into vacuumdb |