Re: Hide 'Execution time' in EXPLAIN (COSTS OFF)

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Christoph Berg <cb(at)df7cb(dot)de>, Andres Freund <andres(at)2ndquadrant(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, ronan(at)dunklau(dot)fr, Markus Wanner <markus(at)bluegap(dot)ch>
Subject: Re: Hide 'Execution time' in EXPLAIN (COSTS OFF)
Date: 2014-09-23 16:41:43
Message-ID: CA+TgmobcTxRLj_-CKkeMHndY5MpBL6BwTGXcc2DWZYdB50qcRw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Sep 20, 2014 at 4:13 PM, Christoph Berg <cb(at)df7cb(dot)de> wrote:
> there's another problem in this area: 9.4 adds "Planning time" to the
> EXPLAIN output. If you don't want to see that, you need to use (costs
> off), but this, well, also disables the costs. If you are running
> regression tests to actually test the costs, you've lost in 9.4.
>
> This problem just emerged in the Multicorn FDW where the regression
> tests were monitoring the costs, but in 9.4 (costs off) kills that.
>
> https://github.com/Kozea/Multicorn/pull/7
>
> Can we have "EXPLAIN (timing off)" in 9.4+ hide the "Planning time"
> line? That would even be backwards compatible with 9.x where it would
> be a no-op.

I don't think that'll work becuase:

/* check that timing is used with EXPLAIN ANALYZE */
if (es.timing && !es.analyze)
ereport(ERROR,
(errcode(ERRCODE_INVALID_PARAMETER_VALUE),
errmsg("EXPLAIN option TIMING
requires ANALYZE")));

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Heikki Linnakangas 2014-09-23 16:46:49 Re: delta relations in AFTER triggers
Previous Message Dmitry Dolgov 2014-09-23 16:23:33 JsonbValue to Jsonb conversion