| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Amit Langote <amitlangote09(at)gmail(dot)com> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Comment in src/backend/commands/vacuumlazy.c |
| Date: | 2014-03-31 14:44:08 |
| Message-ID: | CA+TgmobcHRgLhabnYVLBX+1VfQBeidUz7mGTHJfzxh=n7djaJQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Mar 24, 2014 at 12:28 AM, Amit Langote <amitlangote09(at)gmail(dot)com> wrote:
> Hi,
>
> Note the following comment in src/backend/commands/vacuumlazy.c:lazy_scan_heap()
>
> 1088 /* If no indexes, make log report that lazy_vacuum_heap
> would've made */
> 1089 if (vacuumed_pages)
> 1090 ereport(elevel,
>
> Just wondering if it would read better as:
>
> 1088 /* Make the log report that lazy_vacuum_heap would've made
> had there been no indexes */
>
> Is that correct?
No. Your rewrite means the opposite of what the comment means now.
vacuumed_pages will be non-zero only if the relation does NOT have
indexes.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Heikki Linnakangas | 2014-03-31 15:08:25 | Re: B-Tree support function number 3 (strxfrm() optimization) |
| Previous Message | Stephen Frost | 2014-03-31 14:34:24 | Re: MultiXactId error after upgrade to 9.3.4 |