From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
---|---|
To: | "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com> |
Cc: | Josh berkus <josh(at)agliodbs(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Peter Geoghegan <pg(at)heroku(dot)com>, Noah Misch <noah(at)leadboat(dot)com>, David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, Bruce Momjian <bruce(at)momjian(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Rename max_parallel_degree? |
Date: | 2016-06-03 12:34:47 |
Message-ID: | CA+TgmobYx11xuXy_GtuT=1ejh27K5t-jrc=gOk+XWhxUbpLbkQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Fri, Jun 3, 2016 at 8:30 AM, David G. Johnston
<david(dot)g(dot)johnston(at)gmail(dot)com> wrote:
> How big is the hazard of future-naming this and documenting the present
> limitation? Is the casual user reading explains even going to be aware of
> that particular implementation detail?
Well, see, the nice thing about max_parallel_degree is that it is very
slightly ambiguous, just enough to paper over this. But I'm going to
oppose naming the GUC inaccurately based on a hoped-for future
development project.
Another way to paper over the difference that would be to call this
max_parallel_workers_per_operation. Then we can document that an
operation is a Gather node, and in the future we could document that
it's now a statement. However, if we pick a name like this, then
we're sort of implying that this GUC will control DDL, too.
I think we should just go with max_parallel_workers for a limit on
total parallel workers within max_work_processes, and
max_parallel_workers_per_gather for a per-Gather limit. It's slightly
annoying that we may end up renaming the latter GUC, but not as
annoying as spending another three weeks debating this and missing
beta2.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Amit Kapila | 2016-06-03 13:05:30 | Re: XTM & parallel search |
Previous Message | David G. Johnston | 2016-06-03 12:30:13 | Re: Rename max_parallel_degree? |