| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Amit Kapila <akapila(at)postgresql(dot)org> |
| Cc: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pgsql: Use appropriate wait event when sending data in the apply worker |
| Date: | 2023-02-09 14:26:03 |
| Message-ID: | CA+TgmobWzbr9H3yN3dLVckviEZKemPwd+XyCFKEgyZQZhgP66Q@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Mon, Feb 6, 2023 at 11:40 PM Amit Kapila <akapila(at)postgresql(dot)org> wrote:
> Use appropriate wait event when sending data in the apply worker.
>
> Currently, we reuse WAIT_EVENT_LOGICAL_PARALLEL_APPLY_STATE_CHANGE in the
> apply worker while sending data to the parallel apply worker via a shared
> memory queue. This is not appropriate as one won't be able to distinguish
> whether the worker is waiting for sending data or for the state change.
>
> To patch instead uses the wait event WAIT_EVENT_MQ_SEND which has been
> already used in blocking mode while sending data via a shared memory
> queue.
This is not right at all. You should invent a new wait state if you're
waiting in a new place.
--
Robert Haas
EDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Dunstan | 2023-02-09 18:33:48 | pgsql: Fix help text spacing in pgindent |
| Previous Message | Michael Paquier | 2023-02-09 05:44:37 | pgsql: Fix various typos in code and tests |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tomas Vondra | 2023-02-09 14:29:52 | Re: AW: Wrong rows estimations with joins of CTEs slows queries by more than factor 500 |
| Previous Message | Robert Haas | 2023-02-09 14:22:31 | Re: Weird failure with latches in curculio on v15 |