| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> |
| Subject: | Re: [COMMITTERS] pgsql: Fix a bug in how we generate partition constraints. |
| Date: | 2017-01-13 19:31:10 |
| Message-ID: | CA+TgmobW-320Lhyq+Z4BWzkF9QbjSdj6MH4KNkGDw80zT7LN9A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Fri, Jan 13, 2017 at 2:18 PM, Alvaro Herrera
<alvherre(at)2ndquadrant(dot)com> wrote:
> Robert Haas wrote:
>> Fix a bug in how we generate partition constraints.
>>
>> Move the code for doing parent attnos to child attnos mapping for Vars
>> in partition constraint expressions to a separate function
>> map_partition_varattnos() and call it from the appropriate places.
>
> Hmm, we were discussing this stuff a few days ago, see
> https://www.postgresql.org/message-id/20170109182800.qrkae62kmur3gfeg@alvherre.pgsql
> and commit 3957b58b8885441c8d03bc1cfc00e47cf8cd7975. Part of this code
> duplicates that ...
Is that bad?
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2017-01-13 19:35:25 | Re: [COMMITTERS] pgsql: Fix a bug in how we generate partition constraints. |
| Previous Message | Alvaro Herrera | 2017-01-13 19:18:28 | Re: [COMMITTERS] pgsql: Fix a bug in how we generate partition constraints. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2017-01-13 19:35:25 | Re: [COMMITTERS] pgsql: Fix a bug in how we generate partition constraints. |
| Previous Message | Alvaro Herrera | 2017-01-13 19:18:28 | Re: [COMMITTERS] pgsql: Fix a bug in how we generate partition constraints. |