| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: copyParamList |
| Date: | 2016-07-27 13:15:38 |
| Message-ID: | CA+TgmobW+-1KYtTyAsxiSLZAKwf-c+69tFJbzBPfYdWZ2DTkZw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Jul 27, 2016 at 12:25 AM, Andrew Gierth
<andrew(at)tao11(dot)riddles(dot)org(dot)uk> wrote:
>>>>>> "Robert" == Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> Robert> So I think we instead ought to fix it as in the attached.
>
> Robert> if (retval->paramMask != NULL &&
> Robert> - !bms_is_member(i, retval->paramMask))
> Robert> + !bms_is_member(i, from->paramMask))
>
> Need to change both references to retval->paramMask, not just one.
You are, of course, entirely correct.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2016-07-27 13:16:17 | Re: copyParamList |
| Previous Message | Vik Fearing | 2016-07-27 12:59:17 | Re: PoC: Make it possible to disallow WHERE-less UPDATE and DELETE |