| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
| Cc: | Amul Sul <sulamul(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pg_combinebackup: correct code comment. |
| Date: | 2025-04-15 12:41:33 |
| Message-ID: | CA+TgmobUvsWkKB0SzX6FRtPeNHh0hAJtzHnYMhgbb1+NBF6+0A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Apr 15, 2025 at 3:46 AM Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
> > On 15 Apr 2025, at 06:22, Amul Sul <sulamul(at)gmail(dot)com> wrote:
> > Attached is a patch that corrects the code comment for
> > process_directory_recursively() in pg_combinebackup, where the comment
> > incorrectly refers to "output_directory" instead of the intended
> > "input_directory".
>
> Agreed. The second paragraph in the comment also seem a bit odd, how about the
> below while we are there fixing things?
>
> - * If processing is a user-defined tablespace, the tsoid should be the OID
> + * If processing a user-defined tablespace, the tsoid should be the OID
Yeah, I agree with both of these changes. Feel free to commit, unless
you want me to do it.
--
Robert Haas
EDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | torikoshia | 2025-04-15 13:23:34 | Align memory context level numbering in pg_log_backend_memory_contexts() |
| Previous Message | Peter Eisentraut | 2025-04-15 12:31:50 | Re: [PoC] Federated Authn/z with OAUTHBEARER |