Re: shm_mq fix for non-blocking mode

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: shm_mq fix for non-blocking mode
Date: 2015-10-22 20:45:57
Message-ID: CA+TgmobT2m=cgNeiyR4+XQ_7MatWDdnPdoNMUweEz3HR9eS_tw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Oct 16, 2015 at 5:08 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> The shm_mq code handles blocking mode and non-blocking mode
> asymmetrically in a couple of places, with the unfortunate result that
> if you are using non-blocking mode, and your counterparty dies before
> attaching the queue, operations on the queue continue to return
> SHM_MQ_WOULD_BLOCK instead of, as they should, returning
> SHM_MQ_DETACHED. The attached patch fixes the problem. Thanks to my
> colleague Rushabh Lathia for helping track this down.
>
> (There's are some further bugs in this area outside the shm_mq code
> ... but I'm still trying to figure out exactly what they are and what
> we should do about them. This much, however, seems clear-cut.)

...and so I've committed it and back-patched to 9.4.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2015-10-22 20:50:12 Re: clearing opfuncid vs. parallel query
Previous Message Tom Lane 2015-10-22 20:32:43 Re: clearing opfuncid vs. parallel query