Re: pg_waldump's inclusion of backend headers is a mess

On Tue, Feb 14, 2017 at 12:23 AM, Michael Paquier
<michael(dot)paquier(at)gmail(dot)com> wrote:
> On Tue, Feb 14, 2017 at 12:42 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>> Therefore, I proposed the attached patch, which splits spgxlog.h out
>> of spgist_private.h, nbtxlog.h out of nbtree.h, gistxlog.h out of
>> gist_private.h, and ginxlog.h and ginblock.h out of gin_private.h.
>> These new header files are included by pg_waldump in lieu of the
>> "private" versions. This solves the immediate problem and I suspect
>> it will head off future problems as well.
>>
>> Thoughts, comments, objections, better ideas?
>
> +1 for the overall move. You may want to name the new headers
> dedicated to WAL records with _xlog.h as suffix though, like
> gin_xlog.h instead of ginxlog.h. All the existing RMGRs doing this
> separation (heap, brin, hash and generic) use this format.

I thought about that but it seemed more important to be consistent
with the .c files. generic_xlog.c and brin_xlog.c have an underscore,
but none of the others do. I thought it would be too strange to have
e.g. ginxlog.c and gin_xlog.h.

> The patch looks rather sane to me.

Thanks.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company