| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
| Cc: | Rahila Syed <rahilasyed90(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: show size of DSAs and dshash tables in pg_dsm_registry_allocations |
| Date: | 2025-12-01 15:58:55 |
| Message-ID: | CA+TgmobSKy5g-sb-eSEm48m_Vf5UOOLxy4pynutavUm_D=YF2A@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Dec 1, 2025 at 10:29 AM Nathan Bossart <nathandbossart(at)gmail(dot)com> wrote:
> > 4. Since, with this change, the size column will show memory allocation
> > regardless of whether it is currently mapped in the local process, I
> > think it would be helpful to add a boolean column to display the mapped
> > status as a future enhancement.
>
> Maybe, although I'm struggling to think of a scenario where that
> information would be useful.
I'd be -1 on that idea. I think it's good to keep this as a view of
the global system state, rather than a view of the state of one
particular process.
The patch itself LGTM. I did a casual review only and did not attempt
to verify that it works properly, but I like both the idea and the
execution.
--
Robert Haas
EDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | cca5507 | 2025-12-01 16:05:30 | Re: [Patch] Build the heap more efficient in tuplesort.c |
| Previous Message | Nathan Bossart | 2025-12-01 15:29:43 | Re: show size of DSAs and dshash tables in pg_dsm_registry_allocations |