| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>, Jeff Janes <jeff(dot)janes(at)gmail(dot)com>, Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org>, David Christensen <david(at)endpoint(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] Teach Catalog.pm how many attributes there should be per DATA() line |
| Date: | 2017-03-10 01:57:05 |
| Message-ID: | CA+TgmobSFTTsaMis77OZLZjvfogUKsg1nNYz68M=Xp6gOCM=_Q@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Mar 9, 2017 at 8:47 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> writes:
>> On 2017/03/10 9:14, Jeff Janes wrote:
>>> I think we can just save $. and use that, as in the attached.
>
>> The patch works for me.
>
> Me too. Pushed; we'll soon see if that makes the oldest buildfarm
> critters happy.
$. has been around since the stone age (a.k.a. when I was a teenager)
so we should be fine there. I hope. That whole input_line_number
thing was making me a bit nervous, but I couldn't find any reference
to when that had been added in a quick Google search, which gave me
hope that it was old enough that we'd be OK.
Sorry for the hassle.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2017-03-10 01:59:06 | Re: [COMMITTERS] pgsql: Fix hard-coded relkind constants in pg_dump.c. |
| Previous Message | Andres Freund | 2017-03-10 01:54:44 | Re: [PATCH] Enabling atomics on ARM64 |