Re: [HACKERS] COPY .... WITH (FORMAT binary) causes syntax error at or near "binary"

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Pavel Golub <pavel(at)gf(dot)microolap(dot)com>
Cc: Alvaro Herrera <alvherre(at)commandprompt(dot)com>, pgsql-bugs <pgsql-bugs(at)postgresql(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [HACKERS] COPY .... WITH (FORMAT binary) causes syntax error at or near "binary"
Date: 2011-07-05 15:40:49
Message-ID: CA+TgmobRdj75osiVFdaHDL9C_mkjEpd1RoRmF+vY+EWicW748g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

On Tue, Jul 5, 2011 at 11:37 AM, Pavel Golub <pavel(at)microolap(dot)com> wrote:
> RH> Yeah.  In particular, it conflicts with the ancient copy syntax which
> RH> we still support for backwards compatibility with versions < 7.3.  We
> RH> can fix the immediate problem with something like the attached.
>
> This patch is ugly. Sorry, Robert, but it's true.

No hard feelings here. If you, as the reporter of the problem, don't
feel that it's serious enough to warrant back-patching a fix, then I'm
not going to insist. However, if we don't do what I've proposed here,
then I think 8.4 and 9.0 and probably 9.1 are going to need to stay as
they are, because...

> RH> (c) Should we consider removing compatibility with the ancient copy
> RH> syntax in 9.2, and de-reserving that keyword?  (Given that the
> RH> workaround is this simple, I'm inclined to say "no", but could be
> RH> persuaded otherwise.)
>
> +1 for this. Pre-7.3 syntax is dead in fact for many years.

...this is not something we're going to back-patch.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Tom Lane 2011-07-05 15:50:51 Re: [HACKERS] COPY .... WITH (FORMAT binary) causes syntax error at or near "binary"
Previous Message Pavel Golub 2011-07-05 15:37:15 Re: [HACKERS] COPY .... WITH (FORMAT binary) causes syntax error at or near "binary"

Browse pgsql-hackers by date

  From Date Subject
Next Message Kohei Kaigai 2011-07-05 15:46:06 Re: [v9.2] SECURITY LABEL on shared database object
Previous Message Pavel Golub 2011-07-05 15:37:15 Re: [HACKERS] COPY .... WITH (FORMAT binary) causes syntax error at or near "binary"