Re: Allow to specify #columns in heap/index_form_tuple

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Anastasia Lubennikova <a(dot)lubennikova(at)postgrespro(dot)ru>
Subject: Re: Allow to specify #columns in heap/index_form_tuple
Date: 2017-03-31 17:29:20
Message-ID: CA+TgmobQR2svk1BG=rrQFWqrt_O6YQ3cKaKgpZFmhcKhPHw7ow@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Mar 31, 2017 at 1:24 PM, Andres Freund <andres(at)anarazel(dot)de> wrote:
> The covering indexes patch [1] really needs a version of
> heap_form_tuple/index_form_tuple that allows to specify the number of
> columns in the to-be generated tuple. Previously the faster expression
> evaluation stuff could also have benefited form the same for both
> forming and deforming tuples.
>
> It's obviously trivial to add, codewise.
>
> I think for index_form_tuple we can just add a parameter, but for
> heap_form_tuple/heap_deform_tuple that'd probably break a number of
> external users. How about adding _ex variants that allow to specify
> that?

I think our usual practice is _extended rather than just _ex, but no
objections otherwise.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Masahiko Sawada 2017-03-31 17:35:00 Some never executed code regarding the table sync worker
Previous Message Robert Haas 2017-03-31 17:28:15 Re: [PATCH] Transaction traceability - txid_status(bigint)