Re: [Proposal] Allow users to specify multiple tables in VACUUM commands

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
Cc: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, "Bossart, Nathan" <bossartn(at)amazon(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Subject: Re: [Proposal] Allow users to specify multiple tables in VACUUM commands
Date: 2017-05-18 14:51:59
Message-ID: CA+TgmobPsmDmOEcaU29b0szHfFgjKBdLKjbRcFJk-g=nfVP8rg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, May 18, 2017 at 2:45 AM, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
> On Thu, May 18, 2017 at 3:19 PM, Michael Paquier
> <michael(dot)paquier(at)gmail(dot)com> wrote:
>> On Thu, May 18, 2017 at 2:59 PM, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
>>> It seems to me that it's not good idea to forcibly set ANALYZE in
>>> spite of ANALYZE option is not specified. One reason is that it would
>>> make us difficult to grep it from such as server log. I think It's
>>> better to use the same vacuum option to the all listed relations.
>>
>> Even now, if you use VACUUM without listing ANALYZE directly, with
>> relation listing a set of columns, then ANALYZE is implied.
>
> Oh.. I'd missed that behavior. Thanks!
>
>> I agree
>> with your point that the same options should be used for all the
>> relations, and it seems to me that if at least one relation listed has
>> a column list, then ANALYZE should be implied for all relations.
>
> +1

Ugh, really? Are we sure that the current behavior is anything other
than a bug? The idea that VACUUM foo (a) implies ANALYZE doesn't
really sit very well with me in the first place. I'd be more inclined
to reject that with an ERROR complaining that the column list can't be
specified except for ANALYZE.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2017-05-18 15:03:52 Re: [Proposal] Allow users to specify multiple tables in VACUUM commands
Previous Message Robert Haas 2017-05-18 14:37:33 Re: Proposal: Improve bitmap costing for lossy pages