| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp> |
| Cc: | Peter Geoghegan <pg(at)heroku(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: SortSupport for UUID type |
| Date: | 2015-11-06 17:19:10 |
| Message-ID: | CA+TgmobPizka6kXPfUcaOPwqUGUuVJAX-FggBqf8W942mcbBLA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Nov 6, 2015 at 3:35 AM, Kyotaro HORIGUCHI
<horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp> wrote:
> Hello, I tried to look on this as far as I can referring to
> numeric.c..
Oops, I didn't see this review before committing.
> 6. uuid_abbrev_convert()
>
> > memcpy((char *) &res, authoritative->data, sizeof(Datum));
>
> memcpy's prototype is "memcpy(void *dest..." so the cast to
> (char *) is not necessary.
This is a good catch, so I pushed a fix.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2015-11-06 17:21:50 | Re: Re: BUG #13685: Archiving while idle every archive_timeout with wal_level hot_standby |
| Previous Message | Robert Haas | 2015-11-06 17:18:28 | Re: SortSupport for UUID type |