| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp> |
| Cc: | Sawada Masahiko <sawada(dot)mshk(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: show "aggressive" or not in autovacuum logs |
| Date: | 2017-08-29 01:16:19 |
| Message-ID: | CA+TgmobPJY0qZTr=3kQVbMmBUGguPfYwFLPa30Srbm71RRpcUQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Aug 28, 2017 at 5:26 AM, Kyotaro HORIGUCHI
<horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp> wrote:
> Currently the message shows the '%d skipped-frozen' message but
> it is insufficient to verify the true effect. This is a patch to
> show mode as 'aggressive' or 'normal' in the closing message of
> vacuum. %d frozen-skipped when 'aggressive mode' shows the true
> effect of ALL_FROZEN.
>
> I will add this patch to CF2017-09.
I would be a bit inclined to somehow show aggressive if it's
aggressive and not insert anything at all otherwise. That'd probably
require two separate translatable strings in each case, but maybe
that's OK.
What do other people think?
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Craig Ringer | 2017-08-29 01:26:13 | Re: Custom allocators in libpq |
| Previous Message | Robert Haas | 2017-08-29 01:09:43 | Re: Write operations in parallel mode |