Re: API stability [was: pgsql: Fix possible recovery trouble if TRUNCATE overlaps a checkpoint.]

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Markus Wanner <markus(dot)wanner(at)enterprisedb(dot)com>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>
Subject: Re: API stability [was: pgsql: Fix possible recovery trouble if TRUNCATE overlaps a checkpoint.]
Date: 2022-04-08 15:50:59
Message-ID: CA+TgmobNoa83BmkmLaQDVn=HVs62zsHk+9tZCsxF17a=fV3RVQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Fri, Apr 8, 2022 at 4:47 AM Markus Wanner
<markus(dot)wanner(at)enterprisedb(dot)com> wrote:
> I agree with Michael, it would be nice to not duplicate the code, but
> use a common underlying method. A modified patch is attached.

I don't think this is better, but I don't think it's worth arguing
about, either, so I'll do it this way if nobody objects.

Meanwhile, I've committed the patch for master to master.

--
Robert Haas
EDB: http://www.enterprisedb.com

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2022-04-08 16:36:08 Re: pgsql: Add TAP test for archive_cleanup_command and recovery_end_comman
Previous Message Robert Haas 2022-04-08 15:50:54 pgsql: Rename delayChkpt to delayChkptFlags.

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2022-04-08 15:52:20 Re: Atomic rename feature for Windows.
Previous Message Greg Stark 2022-04-08 15:44:31 Re: Atomic rename feature for Windows.