Re: should we add a XLogRecPtr/LSN SQL type?

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Andres Freund <andres(at)2ndquadrant(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Simon Riggs <simon(at)2ndquadrant(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: should we add a XLogRecPtr/LSN SQL type?
Date: 2014-02-19 15:11:45
Message-ID: CA+TgmobNKoRtuNM_FBQwevtooq5T+pjpKJu5tA5nmYKDnjvkRg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Feb 19, 2014 at 10:03 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
>> On Wed, Feb 19, 2014 at 9:30 AM, Andres Freund <andres(at)2ndquadrant(dot)com> wrote:
>>> GET_8_BYTES only exists for 64bit systems.
>
>> Right, I got that far. So it looks like float8, int8, timestamp,
>> timestamptz, and money all have behavior contingent on
>> USE_FLOAT8_BYVAL, making that symbol a misnomer in every way. But
>> since we've already marched pretty far down that path I suppose we
>> should keep marching.
>
> You need somebody to help you with getting that working on 32-bit
> platforms? Because it needs to get fixed, or reverted, PDQ.

Hopefully the commit I just pushed will fix it. It now works on my
machine with and without --disable-float8-byval.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bernd Helmle 2014-02-19 15:21:12 Re: [HACKERS] Re: pgsql: Add a GUC to report whether data page checksums are enabled.
Previous Message Tom Lane 2014-02-19 15:03:44 Re: should we add a XLogRecPtr/LSN SQL type?