| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Ashwin Agrawal <aagrawal(at)pivotal(dot)io> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Create TOAST table only if AM needs |
| Date: | 2019-05-20 14:29:29 |
| Message-ID: | CA+TgmobMxv3mHO98yXSAkCEJX=0gDL=Kohj_3rq1C6RVvCqUMg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, May 17, 2019 at 5:12 PM Ashwin Agrawal <aagrawal(at)pivotal(dot)io> wrote:
>> I'd rather see this have a relation_ prefix.
>
> +1 to overall patch with that comment incorporated. This seems simple enough to incorporate for v12. Though stating that blind-folded with what else is remaining to be must done for v12.
Rebased and updated patch attached.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-tableam-Move-heap-specific-logic-from-needs_toast.patch | application/octet-stream | 6.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tomas Vondra | 2019-05-20 14:31:52 | Re: Avoiding hash join batch explosions with extreme skew and weird stats |
| Previous Message | Antonin Houska | 2019-05-20 14:03:40 | Inaccurate header comment of issue_xlog_fsync_comment |