Re: pg_*_advice: tsv load failure, etc.

On Thu, Sep 10, 2026 at 10:59 AM Nathan Bossart
<nathandbossart(at)gmail(dot)com> wrote:
> I agree with Melanie. Idea 1 seems like the obvious way to go for v19,
> especially at this stage of the game. In fact, I think there's a good
> argument for keeping it that way long term; I see no benefit to inflicting
> more search_path-style issues unless it provides some huge amount of
> convenience that we simply cannot pass up.

Sounds like a consensus. Here's a new patch set (v5) developed with
that in mind. I've pushed the previous 0001, which was the
documentation fix for GEQO vs. pg_plan_advice, plus a fix for pgindent
breakage reported to me off-list. So now we have:

0001 Change GEQO fitness comparisons to consider disabled_nodes:
Nathan mentioned off-list that it would be good to judge the blast
radius of this change, since it is an ABI break. Although it's a bug
in v18, I only plan to backpatch to v19, so I think it's OK
regardless, but codesearch.debian.net didn't turn up any meaningful
hits for geqo_eval. Is there something else I should be looking at?

0002 Fix defects in JOIN_ORDER advice feedback. Could use review, but
probably won't get anybody, since nobody looks at my code. I think
it's fine, though.

0003 Disallow empty sublists within JOIN_ORDER(). New in this version
of the patch set. Trivial fix for a gap in parse-time validation of
advice strings.

0004 Disallow partition name without partition schema. As per Melanie
and Nathan's preferred direction.

--
Robert Haas
EDB: http://www.enterprisedb.com