Re: minimizing pg_stat_statements performance overhead

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Christoph Berg <myon(at)debian(dot)org>
Cc: Raymond Martin <ramarti(at)microsoft(dot)com>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: minimizing pg_stat_statements performance overhead
Date: 2019-04-03 14:26:22
Message-ID: CA+TgmobJjDh1zAOo9tth43s8ZOXZssvvxXg2n=D94-BrKrMuvg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Apr 2, 2019 at 5:37 AM Christoph Berg <myon(at)debian(dot)org> wrote:
> Re: Raymond Martin 2019-04-01 <BN8PR21MB121708579A3782866DF1F745B1550(at)BN8PR21MB1217(dot)namprd21(dot)prod(dot)outlook(dot)com>
> > Thanks again Fabien. I am attaching the patch to this email in the hope of getting it approved during the next commit fest.
>
> you sent the patch as UTF-16, could you re-send it as plain ascii?

One thing that needs some thought here is what happens if the value of
pgss_enabled() changes. For example we don't want a situation where
if the value changes from off to on between one stage of processing
and another, the server crashes.

I don't know whether that's a risk here or not; it's just something to
think about.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Khandekar 2019-04-03 14:27:33 Re: Minimal logical decoding on standbys
Previous Message Robert Haas 2019-04-03 14:16:02 Re: [HACKERS] WAL logging problem in 9.4.3?