Re: contrib/sepgsql regression tests are a no-go

On Tue, Sep 27, 2011 at 6:30 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>>> I have not touched the documentation, either.  One thing I'd like to do
>>> is adjust both the SGML documentation and the hints printed by the
>>> script to uniformly use "sudo ...root-privileged-command..." rather than
>>> recommending use of "su".
>
>> I think that's your own preference showing.  How about just telling
>> people to run the commands as root without specifying how they should
>> accomplish that?
>
> Well, maybe, but it seems hard to do without being verbose.  If you just
> say
>
>        $ sudo blah blah blah
>
> the meaning is obvious (or if it isn't, you got no business playing with
> SELinux anyway), and you can easily include, or not, the "sudo" part when
> copying and pasting the command.  Right now we've got things like
>
> $ cd .../contrib/sepgsql
> $ make -f /usr/share/selinux/devel/Makefile
> $ su
> # semodule -u sepgsql-regtest.pp
> # semodule -l | grep sepgsql
> sepgsql-regtest 1.03
>
> What I'd prefer is
>
> $ cd .../contrib/sepgsql
> $ make -f /usr/share/selinux/devel/Makefile
> $ sudo semodule -u sepgsql-regtest.pp
> $ sudo semodule -l | grep sepgsql
> sepgsql-regtest 1.03
>
> If I have to break up the recipe with annotations like "run this part as
> root" and then "these commands no longer need root", I don't think
> that's going to be an improvement over either of the above.

Fair enough, I'm not going to get bent out of shape about it. There's
some aesthetic value in the way you're proposing, and anyone who is
doing this ought to know enough to make the details of how you write
it out mostly irrelevant.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company