| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, "Drouvot, Bertrand" <bertranddrouvot(dot)pg(at)gmail(dot)com> |
| Subject: | Re: pgsql: TAP test for logical decoding on standby |
| Date: | 2023-05-23 15:15:58 |
| Message-ID: | CA+TgmobHGpU2ZkChgKifGDLaf_+mFA7njEpeTjfyNf_msCZYew@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Sat, Apr 8, 2023 at 5:26 AM Andres Freund <andres(at)anarazel(dot)de> wrote:
> TAP test for logical decoding on standby
Small nitpicks:
1. The test names generated by check_slots_conflicting_status() start
with a capital letter, while most other test names start with a
lower-case letter.
2. The function is called 7 times, 6 with a true argument and 1 with a
false argument, but the test name only depends on whether the argument
is true or false, so we get the same test name 6 times. Maybe there's
not a reasonable way to do better, I'm not sure, but it's not ideal.
--
Robert Haas
EDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2023-05-23 15:16:10 | pgsql: Fix the install rule for snowball_create.sql. |
| Previous Message | Christoph Berg | 2023-05-23 14:50:25 | Re: pgsql: Move snowball_create.sql creation into perl file |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jacob Champion | 2023-05-23 15:56:47 | Re: [PoC] Federated Authn/z with OAUTHBEARER |
| Previous Message | Hans Buschmann | 2023-05-23 15:09:17 | Re: drop postmaster symlink |