| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Paul Guo <paulguo(at)gmail(dot)com> |
| Cc: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Richard Guo <guofenglinux(at)gmail(dot)com> |
| Subject: | Re: pg_ugprade test failure on data set with column with default value with type bit/varbit |
| Date: | 2018-05-17 13:21:00 |
| Message-ID: | CA+TgmobH1epAZqOO9tfc76org6peRL+gmW6LKDFJrhcXLu9s9A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, May 17, 2018 at 4:20 AM, Paul Guo <paulguo(at)gmail(dot)com> wrote:
> Thanks. I tentatively submitted a patch (See the attachment).
You probably want to add this to the next Commitfest.
> By the way, current pg_upgrade test script depends on the left data on test
> database, but it seems that
> a lot of tables are dropped in those test SQL files so this affects the
> pg_upgrade test coverage much.
> Maybe this needs to be addressed in the future. (Maybe when anyone checks in
> test cases pg_upgrade
> needs to be considered also?)
There's been a deliberate attempt to leave a representative selection
of tables not dropped for this exact reason, but it's definitely
possible that interesting cases have been missed.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2018-05-17 13:29:05 | Re: Incorrect comment in get_partition_dispatch_recurse |
| Previous Message | Michael Paquier | 2018-05-17 13:18:16 | Re: [PATCH] Use access() to check file existence in GetNewRelFileNode(). |