| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Andres Freund <andres(at)2ndquadrant(dot)com>, Noah Misch <noah(at)leadboat(dot)com>, Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Re: Better way of dealing with pgstat wait timeout during buildfarm runs? |
| Date: | 2015-01-19 16:27:51 |
| Message-ID: | CA+TgmobA6WYCM-+fU5HEmtEymeST06o=r+L_fLb-mDDwy2iHfA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Jan 19, 2015 at 11:16 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
>> Sure, but nobody who is not a developer is going to care about that.
>> A typical user who sees "pgstat wait timeout", or doesn't, isn't going
>> to be able to make anything at all out of that.
>
> Possibly we need to improve the wording of that error message then.
> When it was written, we really assumed that it was a can't-happen case
> and so didn't spend much effort on it. Perhaps it should become a
> translatable ereport phrased like "WARNING: using stale statistics
> instead of current ones because stats collector is not responding".
I'm still not completely convinced it deserves to be a WARNING, but I
definitely think turning it into a translatable error message is the
right call. Calling this a "can't happen" case is clearly ridiculous
at this point.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2015-01-19 16:28:41 | Re: Re: Better way of dealing with pgstat wait timeout during buildfarm runs? |
| Previous Message | Andres Freund | 2015-01-19 16:26:03 | Re: Re: Better way of dealing with pgstat wait timeout during buildfarm runs? |