Re: RFC: replace pg_stat_activity.waiting with something more descriptive

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Merlin Moncure <mmoncure(at)gmail(dot)com>
Cc: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: RFC: replace pg_stat_activity.waiting with something more descriptive
Date: 2015-06-22 21:03:40
Message-ID: CA+Tgmob8vksW6ptOMfREFnr6spsxtCf6VjeJp4RCx9Ow9cpBSQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Jun 22, 2015 at 4:40 PM, Merlin Moncure <mmoncure(at)gmail(dot)com> wrote:
> Instead of changing the column, can't we add a new one? Adjusting
> columns in PSA requires the innumerable queries written against it to
> be adjusted along with all the wiki instructions to dev ops for
> emergency stuck query detection etc etc. I would also prefer to
> query 'waiting' in some cases, especially when in emergency
> situations; it's faster to type.

If people feel strongly about backward compatibility, yes, we can do
that. However, if waiting continues to mean "on a heavyweight lock"
for backward compatibility, then you could sometimes have waiting =
false but wait_state non-null. That seems confusing enough to be a
bad plan, at least to me.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2015-06-22 21:05:20 Re: NULL passed as an argument to memcmp() in parse_func.c
Previous Message Merlin Moncure 2015-06-22 20:40:33 Re: RFC: replace pg_stat_activity.waiting with something more descriptive